Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Fix missing peer dependency #30371

Open
wants to merge 5 commits into
base: next
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
CLI: Fix missing peer dependency
  • Loading branch information
valentinpalkovic committed Jan 24, 2025
commit ebe7f62ffcbe6748a90c9be04539a9819754d83a
4 changes: 4 additions & 0 deletions code/frameworks/react-vite/package.json
Original file line number Diff line number Diff line change
@@ -77,11 +77,15 @@
"react": "^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0-beta",
"react-dom": "^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0-beta",
"storybook": "workspace:^",
"typescript": ">= 4.2.x",
"vite": "^4.0.0 || ^5.0.0 || ^6.0.0"
},
"peerDependenciesMeta": {
"@storybook/test": {
"optional": true
},
"typescript": {
"optional": true
}
},
"engines": {
4 changes: 4 additions & 0 deletions code/presets/react-webpack/package.json
Original file line number Diff line number Diff line change
@@ -81,11 +81,15 @@
"typescript": "^5.3.2"
},
"peerDependencies": {
"@storybook/test": "workspace:*",
"react": "^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0-beta",
"react-dom": "^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0-beta",
"storybook": "workspace:^"
},
"peerDependenciesMeta": {
"@storybook/test": {
"optional": true
},
"typescript": {
"optional": true
}
6 changes: 1 addition & 5 deletions code/renderers/react/package.json
Original file line number Diff line number Diff line change
@@ -62,12 +62,8 @@
"prep": "jiti ../../../scripts/prepare/bundle.ts"
},
"dependencies": {
"@storybook/components": "workspace:*",
"@storybook/global": "^5.0.0",
"@storybook/manager-api": "workspace:*",
"@storybook/preview-api": "workspace:*",
"@storybook/react-dom-shim": "workspace:*",
"@storybook/theming": "workspace:*"
"@storybook/react-dom-shim": "workspace:*"
},
"devDependencies": {
"@storybook/test": "workspace:*",
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@ import React from 'react';

import type { Meta } from '@storybook/react';

import { addons } from '@storybook/preview-api';
import { addons } from '@storybook/core/preview-api';

import * as addonActionsPreview from '@storybook/addon-actions/preview';

10 changes: 6 additions & 4 deletions code/yarn.lock
Original file line number Diff line number Diff line change
@@ -8319,10 +8319,13 @@ __metadata:
typescript: "npm:^5.3.2"
webpack: "npm:5"
peerDependencies:
"@storybook/test": "workspace:*"
react: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0-beta
react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0-beta
storybook: "workspace:^"
peerDependenciesMeta:
"@storybook/test":
optional: true
typescript:
optional: true
languageName: unknown
@@ -8478,10 +8481,13 @@ __metadata:
react: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0-beta
react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0-beta
storybook: "workspace:^"
typescript: ">= 4.2.x"
vite: ^4.0.0 || ^5.0.0 || ^6.0.0
peerDependenciesMeta:
"@storybook/test":
optional: true
typescript:
optional: true
languageName: unknown
linkType: soft

@@ -8508,13 +8514,9 @@ __metadata:
version: 0.0.0-use.local
resolution: "@storybook/react@workspace:renderers/react"
dependencies:
"@storybook/components": "workspace:*"
"@storybook/global": "npm:^5.0.0"
"@storybook/manager-api": "workspace:*"
"@storybook/preview-api": "workspace:*"
"@storybook/react-dom-shim": "workspace:*"
"@storybook/test": "workspace:*"
"@storybook/theming": "workspace:*"
"@types/babel-plugin-react-docgen": "npm:^4"
"@types/escodegen": "npm:^0.0.6"
"@types/estree": "npm:^0.0.51"
Loading