Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Upgrade typescript #30354

Draft
wants to merge 15 commits into
base: next
Choose a base branch
from
Draft

Build: Upgrade typescript #30354

wants to merge 15 commits into from

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jan 23, 2025

What I did

I want to use module mocking via the pacjage.json imports field.
However to do that I need a higher version of typescript from what we current use.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.9 MB 77.9 MB 119 B 0.95 0%
initSize 131 MB 131 MB 71.7 kB 3.53 0.1%
diffSize 53 MB 53 MB 71.6 kB 4.92 0.1%
buildSize 7.17 MB 7.17 MB 784 B -0.7 0%
buildSbAddonsSize 1.85 MB 1.85 MB 0 B 1.4 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.86 MB 1.86 MB -12 B -0.82 0%
buildSbPreviewSize 0 B 0 B 0 B - -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.91 MB 3.91 MB -12 B -0.74 0%
buildPreviewSize 3.26 MB 3.27 MB 796 B -0.68 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 15.2s 24.6s 9.3s 1.02 38.1%
generateTime 17.9s 20s 2s -0.26 10.3%
initTime 11.3s 12.9s 1.5s -0.56 11.8%
buildTime 8.4s 10.9s 2.5s 1.27 🔺22.8%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 4.9s 5.5s 635ms 0.05 11.4%
devManagerResponsive 3.6s 4.1s 512ms 0.19 12.3%
devManagerHeaderVisible 699ms 809ms 110ms 0.89 13.6%
devManagerIndexVisible 709ms 833ms 124ms 0.71 14.9%
devStoryVisibleUncached 3.9s 3.9s 2ms 1.43 0.1%
devStoryVisible 730ms 834ms 104ms 0.72 12.5%
devAutodocsVisible 644ms 911ms 267ms 1.86 🔺29.3%
devMDXVisible 619ms 687ms 68ms 0.62 9.9%
buildManagerHeaderVisible 677ms 925ms 248ms 0.7 26.8%
buildManagerIndexVisible 768ms 1s 256ms 0.68 25%
buildStoryVisible 666ms 783ms 117ms 0.31 14.9%
buildAutodocsVisible 683ms 682ms -1ms -0.1 -0.1%
buildMDXVisible 534ms 643ms 109ms 0.66 17%

@ndelangen ndelangen changed the title Buikd: Upgrade typescript Build: Upgrade typescript Jan 23, 2025
@ndelangen ndelangen changed the title Build: Upgrade typescript Build: Upgrade typescript Jan 23, 2025
@ndelangen ndelangen self-assigned this Jan 23, 2025
@ndelangen ndelangen added build Internal-facing build tooling & test updates ci:normal labels Jan 23, 2025
Copy link

nx-cloud bot commented Jan 23, 2025

View your CI Pipeline Execution ↗ for commit 86f6f30.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 53s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-30 15:08:24 UTC

@storybook-pr-benchmarking
Copy link

storybook-pr-benchmarking bot commented Jan 23, 2025

Package Benchmarks

Commit: 86f6f30, ran on 30 January 2025 at 15:11:31 UTC

The following packages have significant changes to their size or dependencies:

@storybook/addon-docs

Before After Difference
Dependency count 17 17 0
Self size 2.20 MB 2.26 MB 🚨 +61 KB 🚨
Dependency size 7.92 MB 7.92 MB 0 B
Bundle Size Analyzer Link Link

@storybook/addon-essentials

Before After Difference
Dependency count 36 36 0
Self size 12 KB 12 KB 0 B
Dependency size 13.87 MB 13.93 MB 🚨 +61 KB 🚨
Bundle Size Analyzer Link Link

@storybook/addon-storysource

Before After Difference
Dependency count 7 7 0
Self size 1.89 MB 1.89 MB 0 B
Dependency size 10.74 MB 10.80 MB 🚨 +63 KB 🚨
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 388 388 0
Self size 503 KB 503 KB 🎉 -310 B 🎉
Dependency size 75.28 MB 75.35 MB 🚨 +75 KB 🚨
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 277 277 0
Self size 612 KB 617 KB 🚨 +6 KB 🚨
Dependency size 65.36 MB 65.43 MB 🚨 +70 KB 🚨
Bundle Size Analyzer Link Link

@storybook/source-loader

Before After Difference
Dependency count 5 5 0
Self size 41 KB 41 KB 0 B
Dependency size 10.68 MB 10.75 MB 🚨 +63 KB 🚨
Bundle Size Analyzer Link Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants