Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mock issue resolved for circular ref #2563

Closed
wants to merge 2 commits into from

Conversation

SB-rohitdesai
Copy link
Contributor

@SB-rohitdesai SB-rohitdesai commented Jul 16, 2024

Addresses #STOP-184

Summary

Getting 500 Error or Sometimes might need to wait a long time before getting this error when spec having circular references

Checklist

  • The basics
    • I tested these changes manually in my local or dev environment
  • Tests
    • Added or updated
    • N/A
  • Event Tracking
    • I added event tracking and followed the event tracking guidelines
    • N/A
  • Error Reporting
    • I reported errors and followed the error reporting guidelines
    • N/A

@SB-rohitdesai SB-rohitdesai requested a review from a team as a code owner July 16, 2024 19:11
@@ -58,7 +58,7 @@ const mock: IPrismComponents<IHttpOperation, IHttpRequest, IHttpResponse, IHttpM
config,
}) => {
const payloadGenerator: PayloadGenerator = config.dynamic
? partial(generate, resource, resource['__bundle__'])
? partial(generate, resource, resource['__bundled__'])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this has changed ?? how it was working previously?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dereferencing was properly working with previous code (resource['bundle']) But getting issue in the API response. So due that I make change here.

Copy link

@bhaskarsontakke bhaskarsontakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link

@prafullaAtSB prafullaAtSB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants