Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): release please without root again #2558

Merged
merged 1 commit into from
Aug 8, 2024
Merged

chore(ci): release please without root again #2558

merged 1 commit into from
Aug 8, 2024

Conversation

brendarearden
Copy link
Contributor

@brendarearden brendarearden commented Jul 3, 2024 •
edited
Loading

Addresses STOP-537

Summary

Having the root in the release-please configuration causes it to keep creating a release PR and version bump. By removing this, it will keep the release PRs from getting caught in a loop.

  • remove root from release please config
  • deprecates the root changelog in favor of the individual package changelogs

Checklist

  • The basics
    • I tested these changes manually in my local or dev environment
  • Tests
    • Added or updated
    • N/A
  • Event Tracking
    • I added event tracking and followed the event tracking guidelines
    • N/A
  • Error Reporting
    • I reported errors and followed the error reporting guidelines
    • N/A

@brendarearden brendarearden mentioned this pull request Jul 3, 2024
Closed
7 tasks
@brendarearden brendarearden force-pushed the chore/trying-new-config-release-please branch from fc911c2 to 6697aa3 Compare July 24, 2024 17:16
@brendarearden brendarearden force-pushed the chore/trying-new-config-release-please branch from 6697aa3 to 8f1434a Compare July 24, 2024 17:32
@brendarearden brendarearden marked this pull request as ready for review July 24, 2024 17:34
@brendarearden brendarearden requested a review from a team as a code owner July 24, 2024 17:34
@lukaszm-sb lukaszm-sb mentioned this pull request Aug 6, 2024
Closed
lukaszzazulak
lukaszzazulak approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@lukaszzazulak lukaszzazulak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, let's try to remove the root from release please and go back to previous working solution.

@lukaszzazulak lukaszzazulak merged commit 2896e41 into master Aug 8, 2024
9 checks passed
@lukaszzazulak lukaszzazulak deleted the chore/trying-new-config-release-please branch August 8, 2024 11:12
@lukaszzazulak lukaszzazulak mentioned this pull request Aug 8, 2024
Merged
7 tasks
dgellow added a commit to stainless-api/prism that referenced this pull request Aug 20, 2024
@dgellow @SB-rohitdesai
@brendarearden @lukaszzazulak @stoplight-bot
chore: sync from upstream (#6)
ea15821 
* fix: version update and bundled_issue changes (stoplightio#2577)

* chore(ci): release please without root again (stoplightio#2558)

* chore(ci): release please without root (stoplightio#2583)

* chore(ci): back to release please without root p2 (stoplightio#2584)

* chore(ci): revert attempt to fix release please (stoplightio#2587)

* chore: release master (stoplightio#2586)

Co-authored-by: lukasz.zazulak <lukasz.zazulak@smartbear.com>

---------

Co-authored-by: SB-rohitdesai <165134671+SB-rohitdesai@users.noreply.github.com>
Co-authored-by: Brenda Rearden <brendarearden@gmail.com>
Co-authored-by: lukaszzazulak <155975313+lukaszzazulak@users.noreply.github.com>
Co-authored-by: Stoplighticus Roboticus <43760305+stoplight-bot@users.noreply.github.com>
Co-authored-by: lukasz.zazulak <lukasz.zazulak@smartbear.com>
ilanashapiro pushed a commit to ilanashapiro/prism that referenced this pull request Aug 22, 2024
@brendarearden @ilanashapiro
chore(ci): release please without root again (stoplightio#2558)
f881b9e
dgellow added a commit to stainless-api/prism that referenced this pull request Jan 16, 2025
@dgellow @SB-rohitdesai
@brendarearden @lukaszzazulak @stoplight-bot @dependabot @ilanashapiro @bo-acc @mnaumanali94 @PixnBits
chore: sync with upstream (#7)
21985a2 
* fix: version update and bundled_issue changes (stoplightio#2577)

* chore(ci): release please without root again (stoplightio#2558)

* chore(ci): release please without root (stoplightio#2583)

* chore(ci): back to release please without root p2 (stoplightio#2584)

* chore(ci): revert attempt to fix release please (stoplightio#2587)

* chore: release master (stoplightio#2586)

Co-authored-by: lukasz.zazulak <lukasz.zazulak@smartbear.com>

* fix: reverted changes and bump the JSON version (stoplightio#2598)

* chore: release master (stoplightio#2588)

Co-authored-by: sb-rohitdesai <rohitkumar.desai@smartbear.com>

* chore(deps): bump micromatch from 4.0.5 to 4.0.8 (stoplightio#2597)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump axios from 1.7.2 to 1.7.7 (stoplightio#2604)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump fast-xml-parser from 4.3.2 to 4.4.1 (stoplightio#2570)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(readme): update roadmap links (stoplightio#2555)

* feat: add --seed CLI flag for deterministic generation of dynamic examples (stoplightio#2594)

* chore(deps-dev): bump json-schema-faker from 0.5.6 to 0.5.8 (stoplightio#2627)

* chore: fix circle ci config (stoplightio#2628)

* chore: release master (stoplightio#2606)

* fix(http): update json-path plus in http

* chore: release master (stoplightio#2629)

* chore(deps): bump cross-spawn from 7.0.3 to 7.0.6 (stoplightio#2635)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump micromatch from 4.0.5 to 4.0.8 (stoplightio#2633)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump axios from 1.7.2 to 1.7.7 (stoplightio#2631)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* refactor(docker): AS casing match FROM (stoplightio#2621)

* fix(Docker): use tini to handle kernel signals (stoplightio#2622)

* chore(deps): bump split2 and @types/split2 (stoplightio#2615)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump form-data from 4.0.0 to 4.0.1 (stoplightio#2616)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump tmp from 0.2.1 to 0.2.3 (stoplightio#2613)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump braces from 3.0.2 to 3.0.3 (stoplightio#2632)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump nanoid from 3.3.7 to 3.3.8 (stoplightio#2646)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump @stoplight/yaml from 4.2.3 to 4.3.0 (stoplightio#2641)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump husky from 8.0.3 to 9.1.7 (stoplightio#2637)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Run yarn install

* Add stainless github CI

* Use explicit deps versions

* Fix prettier issue

* Fix

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: SB-rohitdesai <165134671+SB-rohitdesai@users.noreply.github.com>
Co-authored-by: Brenda Rearden <brendarearden@gmail.com>
Co-authored-by: lukaszzazulak <155975313+lukaszzazulak@users.noreply.github.com>
Co-authored-by: Stoplighticus Roboticus <43760305+stoplight-bot@users.noreply.github.com>
Co-authored-by: lukasz.zazulak <lukasz.zazulak@smartbear.com>
Co-authored-by: sb-rohitdesai <rohitkumar.desai@smartbear.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ilana Shapiro <ishapiro00@gmail.com>
Co-authored-by: Bogdan O. <bogdan.oniga@accelins.com>
Co-authored-by: Nauman <mnaumanali94@gmail.com>
Co-authored-by: Nick Oliver <git@pixnbits.org>
Co-authored-by: Nick Oliver <i@pixnbits.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszzazulak lukaszzazulak lukaszzazulak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brendarearden @lukaszzazulak