Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename player identities #626

Closed
sussexrick opened this issue Sep 28, 2022 · 0 comments
Closed

Rename player identities #626

sussexrick opened this issue Sep 28, 2022 · 0 comments
Assignees
@sussexrick
Labels
statistics Player, match or team statistics

Comments

@sussexrick
Copy link
Member

sussexrick commented Sep 28, 2022 •
edited
Loading

It should be possible to rename a player identity which is misspelled or incomplete. This issue covers changing to a new name that is still unique. If the name is already in use that is #118.

This might be for members to do themselves, or team owners, or both. Decision - just team owners, to keep it simple. Members can link players or talk to their team owner.

For team owner UX it could be an 'Edit player' page with just the name for starters, extended by #627 and then #118.

The PlayerIdentity record can be updated immediately, but the derived statistics must be updated in small batches by a HostedService outside the main request, to avoid SQL timeouts. Therefore the standard warning about statistics not updating immediately must be displayed.
@sussexrick sussexrick added the statistics Player, match or team statistics label Sep 28, 2022
@sussexrick sussexrick mentioned this issue Oct 2, 2022
Open
11 tasks
@sussexrick sussexrick pinned this issue Nov 21, 2022
sussexrick added a commit that referenced this issue Jan 8, 2023
@sussexrick
Create an 'edit players for team' page #626
cc4d06b
sussexrick added a commit that referenced this issue Jan 8, 2023
@sussexrick
Refactor breadcrumb code out of team controllers #626
de1415a
sussexrick added a commit that referenced this issue Jan 8, 2023
@sussexrick
Generate a new RouteSegment for each player identity, unique within t…
b7a7cf8 
…he team #626
sussexrick added a commit that referenced this issue Jan 8, 2023
@sussexrick
Create a page which presents a player identity to be renamed, and a s…
ef35002 
…urface controller which handles an empty field #626
sussexrick added a commit that referenced this issue Jan 8, 2023
@sussexrick
Rename a player identity if the new name is unique within the team #626
aeab571
sussexrick added a commit that referenced this issue Jan 8, 2023
@sussexrick
Add auditing and logging when renaming a player identity #626
014f666
@sussexrick sussexrick self-assigned this Jan 8, 2023
sussexrick added a commit that referenced this issue Jan 9, 2023
@sussexrick
When renaming player identities, ensure route and comparable name are…
0bf0654 
… updated for the identity #626
sussexrick added a commit that referenced this issue Jan 9, 2023
@sussexrick
Update player route if required following renaming of a player identity
8b8e49c 
#626
sussexrick added a commit that referenced this issue Jan 12, 2023
@sussexrick
Fix unit tests following previous commit #626
1c488db
sussexrick added a commit that referenced this issue Jan 12, 2023
@sussexrick
Clear cache when renaming players so that the 'edit players' list upd…
59ed218 
…ates #626
sussexrick added a commit that referenced this issue Jan 14, 2023
@sussexrick
Update content from live, and add a new page about how to manage the …
d020d8c 
…players listed for your team. #626
sussexrick added a commit that referenced this issue Jan 14, 2023
@sussexrick
Renaming a player identity should apply the same formatting as creati…
59f297a 
…ng a player identity on a scorecard #626
sussexrick added a commit that referenced this issue Jan 14, 2023
@sussexrick
When a player identity name was just punctuation, it got stripped and…
102e6a7 
… generated an empty route. Ensure there is a route. #626
@sussexrick sussexrick unpinned this issue Jan 14, 2023
sussexrick added a commit that referenced this issue Jan 15, 2023
@sussexrick
Fix missing club in breadcrumb trail #626 #650
acf54d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sussexrick sussexrick

Labels
statistics Player, match or team statistics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sussexrick