Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When one innings has batting and one has just a total, totals don't line up #603

Open
sussexrick opened this issue May 22, 2022 · 2 comments
Labels
bug Something isn't working design CSS or layout improvements good first issue Good for newcomers

Comments

@sussexrick
Copy link
Member

sussexrick commented May 22, 2022

How to reproduce

At the time of writing this is a live example.

Create a match in the past and update the result. In the first batting innings add at least one batter to the scorecard and fill in the total runs for the innings and wickets taken. Don't fill in any bowling data. In the second batting innings don't fill in details of any batters but just add the total score and wickets taken. When you save the match and view the scorecard the alignment will be as shown in this screenshot.

image

Change required

The first batting innings uses the full scorecard display. Find out the width setting on the 'Balls' column.

The second batting innings uses the minimal scorecard display. Add some right padding equal to the width of the 'Balls' column so that 'Total' and 'Wickets' labels and the 'Runs' column line up. Minimal scorecards can always use this spacing even when there are two minimal scorecards and no full scorecard.

These tables adjust responsively to mobile and tablet screen sizes. The small screen layout should not be changed:

image

@sussexrick sussexrick added bug Something isn't working good first issue Good for newcomers design CSS or layout improvements labels May 22, 2022
@Developing-Developer2019

Do you want the Total above to be on the right? Not sure I'm following from whats mentioned sorry

@sussexrick
Copy link
Member Author

@Developing-Developer2019 Sorry I'd just written it up as a 'note to self' but I've fleshed out the detail a lot more now. It would be amazing to have you contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design CSS or layout improvements good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants