Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky tests: MaxResults integration tests #595

Open
2 tasks
sussexrick opened this issue Mar 28, 2022 · 0 comments
Open
2 tasks

Flaky tests: MaxResults integration tests #595

sussexrick opened this issue Mar 28, 2022 · 0 comments
Labels
bug Something isn't working tests Create unit or UI tests

Comments

@sussexrick
Copy link
Member

sussexrick commented Mar 28, 2022

This is almost certainly down to suitable test data not being generated reliably, rather than a problem with the code being tested.

Rethink how it's done - a test suite should update the data, run tests on it, then roll back the transaction, using the same database as other tests, rather than creating a separate database.

  • ReadBowlingFiguresMaxResultsTests.Read_bowling_figures_with_MaxResultsAllowingExtraResultsIfValuesAreEqual_returns_results_equal_to_the_max
  • ReadPlayerInningsMaxResultsTests.Read_player_innings_with_MaxResultsAllowingExtraResultsIfValuesAreEqual_returns_results_equal_to_the_max

On line 140 of SqlServerStatisticsMaxResultsDataSourceFixture the sixth bowler had no overs with runs conceded, and that threw an exception. That made both tests fail because the fixture was unavailable.

@sussexrick sussexrick added bug Something isn't working tests Create unit or UI tests labels Mar 28, 2022
@sussexrick sussexrick changed the title MaxResults integration tests are flaky Some integration tests are flaky Nov 16, 2022
@sussexrick sussexrick changed the title Some integration tests are flaky MaxResults integration tests are flaky Nov 16, 2022
@sussexrick sussexrick changed the title MaxResults integration tests are flaky Flaky tests: MaxResults integration tests Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Create unit or UI tests
Projects
None yet
Development

No branches or pull requests

1 participant