Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.4.2 #298

Merged
merged 3 commits into from
Sep 4, 2024
Merged

v1.4.2 #298

merged 3 commits into from
Sep 4, 2024

Conversation

jhollway
Copy link
Collaborator

@jhollway jhollway commented Sep 4, 2024

Description

2024-09-04

Package

  • Using github actions download artifact v4 to address dependabot security warning

Models

  • test_permutation() now uses manynet::to_permuted() instead of the older
    manynet::generate_permutation() syntax

Checklist:

  • Documentation
    • Any longer functions are commented inline so that it is easier to debug in the future
    • Any new or modified functions or data have roxygen style documentation in their .R scripts
    • DESCRIPTION file version is bumped by the appropriate increment (major, minor, patch)
  • PR form
    • Title indicates expected version number
    • PR description above and the NEWS.md file are aligned
    • Any closed, fixed, or related issues are referenced and described, e.g. "Fixed #0 by adding A"
  • PR checks all pass for latest commit
    • Package builds on my OS without issues
    • CodeFactor check: Package improves or maintains good style
    • Package builds on Mac
    • Package builds on Windows
    • Package builds on Linux
    • CodeCov check: Package improves or maintains good test coverage

@jhollway jhollway merged commit fbeaea8 into main Sep 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant