Raise minimum Go version to 1.21 #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There have apparently been some bug fixes related to generics in recent releases. This causes problems when using Gofish with older Go releases where it does not like the contraints defined on some of the recent updates using generics. This raises our minimum to 1.21 as this is a version known to work. While I would have liked to keep the minimum version older to give more flexibility to library consumers, there are multiple good reasons to update to the newer release. I do feel bad about the very short notice though. Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
stmcginnis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have apparently been some bug fixes related to generics in recent releases. This causes problems when using Gofish with older Go releases where it does not like the contraints defined on some of the recent updates using generics. This raises our minimum to 1.21 as this is a version known to work.
While I would have liked to keep the minimum version older to give more flexibility to library consumers, there are multiple good reasons to update to the newer release. I do feel bad about the very short notice though.