Add generic object retrieval #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Now that the minimum Go version has been raised to 1.1 we can use generics. This allows us to simplify a lot of the GetXXX calls to use common code and avoid a lot of duplication. Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've moved to Go 1.18 as a minimum we can use generics. This consolidates a lot of the GetXXX calls to use common code to retrieve API objects.
Also cleans up some other code and fixes a couple small bugs.