0049 stl forest park advisory #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I usually just use |
ledaliang
reviewed
Aug 13, 2020
city_scrapers/settings/base.py
Outdated
| @@ -18,7 +18,7 @@ | |||
| USER_AGENT = "City Scrapers [development mode]. Learn more and say hello at https://www.citybureau.org/city-scrapers/" | |||
|
|
|||
| # Obey robots.txt rules | |||
| ROBOTSTXT_OBEY = True | |||
| ROBOTSTXT_OBEY = False | |||
There was a problem hiding this comment.
Since you added custom_settings in the spider itself, you can change this back to True. We would like to avoid changing the settings.
There was a problem hiding this comment.
Yeah, this was from trying stuff out on scrapy shell, will revert
ledaliang
reviewed
Aug 13, 2020
Comment on lines
+104
to
+108
| def _parse_title(self, response): | ||
| title = response.xpath('//*/div[@class="EventTitle"]/text()').get() | ||
| title = title.replace("\n", "") | ||
|
|
||
| return title |
There was a problem hiding this comment.
This may not be necessary, since all of the titles are "Forest Park Advisory Board".
ledaliang
reviewed
Aug 13, 2020
Comment on lines
+110
to
+123
| def _parse_desc(self, response): | ||
| descs = response.xpath( | ||
| '//*/div[@id="EventDisplayBlock"]/div[@class="row"]/div/p/text()' | ||
| ).getall() | ||
| description = "" | ||
| for desc in descs: | ||
| if desc == "\n": | ||
| desc = "" | ||
| else: | ||
| desc = desc.replace("\xa0", "") | ||
| desc = desc.replace("\n", "") | ||
| description = description + desc | ||
|
|
||
| return description |
There was a problem hiding this comment.
The descriptions describe the board and not the meeting so we don't need it.
ledaliang
reviewed
Aug 13, 2020
Comment on lines
+62
to
+86
| def _parse_event(self, response): | ||
|
|
||
| start = self._parse_start(response) | ||
| links_key = datetime.strftime(start, "%Y-%m-%d") | ||
|
|
||
| meeting = Meeting( | ||
| title=self._parse_title(response), | ||
| description=self._parse_desc(response), | ||
| classification=BOARD, | ||
| start=start, | ||
| end=self._parse_end(response), | ||
| all_day=False, | ||
| location=self._parse_location(response), | ||
| source=response.url, | ||
| ) | ||
|
|
||
| meeting["links"] = [] | ||
|
|
||
| if links_key in self.agenda_map.keys(): | ||
| meeting["links"].append(self.agenda_map[links_key]) | ||
|
|
||
| if links_key in self.minute_map.keys(): | ||
| meeting["links"].append(self.minute_map[links_key]) | ||
|
|
||
| return meeting |
There was a problem hiding this comment.
Parse the status and id for each meeting like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue: 0049
Checklist
All checks are run in GitHub Actions. You'll be able to see the results of the checks at the bottom of the pull request page after it's been opened, and you can click on any of the specific checks listed to see the output of each step and debug failures.
Questions
My spider seems to be working, but the tests return weird whitespace in the title, description, and links.