Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise: additions needed for chainfile #4

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

claymcleod
Copy link
Member

  • Contigs can now be created from Strings.
  • Added the following methods to Interval:
    • into_start()
    • into_end()
    • coordinate_at_offset()
  • Adds the into_equivalent_base() and into_equivalent_interbase() methods for interbase and base intervals respectively.
  • Extends the position-u64 feature to the top-level omics crate.

Copy link

github-actions bot commented Jan 3, 2025

🐰 Bencher Report

Branchmain
Testbedgithub-actions

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
contig::new📈 view plot
⚠️ NO THRESHOLD
10.94
coordinates::interbase::try_new📈 view plot
⚠️ NO THRESHOLD
19.91
intervals::interbase::try_new📈 view plot
⚠️ NO THRESHOLD
54.39
positions::base::checked_add📈 view plot
⚠️ NO THRESHOLD
2.19
positions::base::checked_sub📈 view plot
⚠️ NO THRESHOLD
1.87
positions::base::try_new📈 view plot
⚠️ NO THRESHOLD
0.42
positions::interbase::checked_add📈 view plot
⚠️ NO THRESHOLD
1.56
positions::interbase::checked_sub📈 view plot
⚠️ NO THRESHOLD
1.56
positions::interbase::new📈 view plot
⚠️ NO THRESHOLD
0.31
🐰 View full continuous benchmarking report in Bencher

* `Contig`s can now be created from `String`s.
* Added the following methods to `Interval`:
  * `into_start()`
  * `into_end()`
  * `coordinate_at_offset()`
* Adds the `into_equivalent_base()` and `into_equivalent_interbase()`
  methods for interbase and base intervals respectively.
* Extends the `position-u64` feature to the top-level `omics` crate.
@claymcleod claymcleod force-pushed the revise/chainfile-additions branch from 893254f to 19d144d Compare January 3, 2025 17:26
@claymcleod claymcleod merged commit c31175b into main Jan 3, 2025
8 checks passed
@claymcleod claymcleod deleted the revise/chainfile-additions branch January 3, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant