-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Towards #2668) Implementation of keyword arguments to transformations instead of options dict. #2877
base: master
Are you sure you want to change the base?
Conversation
…o replace options. Docs not yet done, need to add it to a subclass to do real testing
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2877 +/- ##
==========================================
- Coverage 99.89% 99.85% -0.05%
==========================================
Files 359 359
Lines 50995 51178 +183
==========================================
+ Hits 50940 51102 +162
- Misses 55 76 +21 ☔ View full report in Codecov by Sentry. |
@arporter @sergisiso I added a basic idea for the decorator to the utils. It currently doesn't work correctly in a couple of ways:
Point 1 is fine to fix once I'm happy with the apply change. I've not yet tested what sphinx gives me for it - python doc is correctly updated, I'll try to build the docs and check ParallelLoopTrans docs. Update: Sphinx does appear to give me something I expect - there are warnings on github that I can't reproduce locally, but it seems to just be missing blank lines I think? So potentially an easy fix. The picture below has inherited the |
Docs still fail here, but I can't duplicate it locally so I can't diagnose it - for me the docs build and look ok. There's some warning to do with line indentation/breaks but I can't work out what it means. |
This is still an early draft - documentation not yet handled.
This doesn't replace options at current, merely provides an alternative, more pythonic approach. Removing options would be a future issue for a large release of PSyclone, unlikely to happen in the immediate future.