EDIT comment not working

[scottdorman]

This may be due to newer versions of Visual Studio, but it appears that the "EDIT" comment support isn't working anymore. In Visual Studio 2022 (running community edition, and haven't tested this in any other versions or editions), comments are stored in the regex XML as all lowercase, so the Contains("EDIT") calls always return false.

This affects the following call sites:

ResxTranslator/Translator.cs

Line 358 in 725492d

var editing = data[index].Element("comment")?.Value.Contains("EDIT") == true;

ResxTranslator/Translator.cs

Line 481 in 725492d

.Where(e => e.Value.Contains("EDIT"));

and may also affect the REGEX at

ResxTranslator/Translator.cs

Line 468 in 725492d

return Regex.Replace(comment, @"\s*EDIT\s*", string.Empty);

If you retarget this to .NET 5.0+, you can use an overload on Contains that takes a StringComparison parameter.

[scottdorman]

I can manually edit the XML to change the comment to uppercase, which works around the issue but is counterproductive.

[stevencohn]

Sorry I just saw this. I keep VS updated and haven't seen this but I'll take a look. Thanks