Fix memory issue

stevehjohn · Aug 11, 2024 · 134405c · 134405c
1 parent 5fbb06c
commit 134405c
Showing 1 changed file with 27 additions and 23 deletions.
diff --git a/src/Zen.Desktop.Host/Features/SpectrumAnalyser.cs b/src/Zen.Desktop.Host/Features/SpectrumAnalyser.cs
@@ -40,6 +40,10 @@ public class SpectrumAnalyser
 
     private readonly Color[] _palette;
 
+    private readonly float[] _magnitudes;
+
+    private readonly float[] _groupedMagnitudes;
+
     private readonly FrequencyRange[] _frequencyRanges =
     [
         new FrequencyRange(30, 40),
@@ -73,6 +77,10 @@ public SpectrumAnalyser(GraphicsDeviceManager graphicsDeviceManager)
 
         _peakTimes = new long[4][];
 
+        _magnitudes = new float[BufferSize];
+
+        _groupedMagnitudes = new float[_frequencyRanges.Length];
+
         for (var i = 0; i < 4; i++)
         {
             _buffers[i] = new Complex[BufferSize];
@@ -150,35 +158,31 @@ private void RenderSpectrumChannel(int channel)
 
         var height = Constants.ScreenHeightPixels / 4;
 
-        var magnitudes = new float[_buffers[channel].Length];
-
         var axis = height * Constants.SpectrumVisualisationPanelWidth * (channel + 1) - Constants.SpectrumVisualisationPanelWidth;
 
-        for (var i = 0; i < magnitudes.Length; i++)
+        for (var i = 0; i < _magnitudes.Length; i++)
         {
-            magnitudes[i] = (float) Math.Sqrt(_buffers[channel][i].Real * _buffers[channel][i].Real + _buffers[channel][i].Imaginary * _buffers[channel][i].Imaginary);
+            _magnitudes[i] = (float) Math.Sqrt(_buffers[channel][i].Real * _buffers[channel][i].Real + _buffers[channel][i].Imaginary * _buffers[channel][i].Imaginary);
         }
 
-        var groupedMagnitudes = new float[_frequencyRanges.Length];
-
         for (var i = 0; i < _frequencyRanges.Length; i++)
         {
-            var lowBin = (int)Math.Round(_frequencyRanges[i].Low * BufferSize / System.Modules.Audio.Constants.SampleRate);
-            var highBin = (int)Math.Round(_frequencyRanges[i].High * BufferSize / System.Modules.Audio.Constants.SampleRate);
+            var lowBin = (int) Math.Round(_frequencyRanges[i].Low * BufferSize / System.Modules.Audio.Constants.SampleRate);
+            var highBin = (int) Math.Round(_frequencyRanges[i].High * BufferSize / System.Modules.Audio.Constants.SampleRate);
 
             float sum = 0;
 
             for (var j = lowBin; j <= highBin; j++)
             {
-                sum += magnitudes[j];
+                sum += _magnitudes[j];
             }
 
-            groupedMagnitudes[i] = sum / (highBin - lowBin + 1);
+            _groupedMagnitudes[i] = sum / (highBin - lowBin + 1);
         }
 
         for (var i = 0; i < _frequencyRanges.Length; i++)
         {
-            var dataPoint = groupedMagnitudes[i] / MagnitudeDivisor;
+            var dataPoint = _groupedMagnitudes[i] / MagnitudeDivisor;
 
             var peak = (int) (dataPoint * height * (channel == 3 ? 1 : 4));
 
@@ -219,18 +223,6 @@ private void RenderSpectrumChannel(int channel)
             }
         }
     }
-
-    private class FrequencyRange
-    {
-        public float Low { get; }
-        public float High { get; }
-
-        public FrequencyRange(float low, float high)
-        {
-            Low = low;
-            High = high;
-        }
-    }
 
     private static class PaletteGenerator
     {
@@ -271,4 +263,16 @@ public static Color[] GetPalette(int steps, Color[] markers)
             return palette;
         }
     }
+
+    private class FrequencyRange
+    {
+        public float Low { get; }
+        public float High { get; }
+
+        public FrequencyRange(float low, float high)
+        {
+            Low = low;
+            High = high;
+        }
+    }
 }