Only generate base instance factory when required

stephenh · Dec 2, 2024 · 1a15e45 · 1a15e45
1 parent 6c8c10f
commit 1a15e45
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 61 deletions.
diff --git a/integration/output-decode-include-types/encode.ts b/integration/output-decode-include-types/encode.ts
diff --git a/integration/output-encode-decode-include-types-combined/request_response.ts b/integration/output-encode-decode-include-types-combined/request_response.ts
diff --git a/integration/output-encode-include-types/encode.ts b/integration/output-encode-include-types/encode.ts
diff --git a/integration/output-encode-only/encode.ts b/integration/output-encode-only/encode.ts
diff --git a/integration/output-encode-only/google/protobuf/wrappers.ts b/integration/output-encode-only/google/protobuf/wrappers.ts
diff --git a/src/main.ts b/src/main.ts
@@ -210,7 +210,12 @@ export function generateFile(ctx: Context, fileDesc: FileDescriptorProto): [stri
 
         // Only decode, fromPartial, and wrap use the createBase method
         if (
-          (options.outputEncodeMethods && options.outputEncodeMethods !== "encode-no-creation") ||
+          (
+            options.outputEncodeMethods &&
+            options.outputEncodeMethods !== "encode-no-creation" &&
+            options.outputEncodeMethods !== "encode-only" &&
+            (options.outputDecodeIncludeTypes === "" || new RegExp(options.outputDecodeIncludeTypes).test(fullTypeName))
+          ) ||
           options.outputPartialMethods ||
           outputWrapAndUnwrap
         ) {