Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: Improve error messages when decoding #200

Open
leighmcculloch opened this issue Jul 12, 2024 · 1 comment
Open

Rust: Improve error messages when decoding #200

leighmcculloch opened this issue Jul 12, 2024 · 1 comment

Comments

@leighmcculloch
Copy link
Member

leighmcculloch commented Jul 12, 2024

@2opremio pointed out here that the Rust generated codes error messages when decoding types is not particularly informative, especially in comparison to the Go decoder that xdrgen generates.

We should see how we can improve the Rust decoder so it is more informative and learns from investments in error messages we made in the Go decoder.

@leighmcculloch
Copy link
Member Author

For example, when the decoder (via the CLI) sees a trailing byte that is unexpected, it returns this error:

error decoding XDR: Invalid byte 10, offset 220. 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant