-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace getLedgerEntries()
with a proxy to Core's /getledgerentry
.
#269
Labels
Milestone
Comments
Shaptic
changed the title
Replace
Replace Aug 13, 2024
getLedgerEntries()
implementation with a proxy to Core's /getledgerentrybulk
.getLedgerEntries()
with a proxy to Core's /getledgerentrybulk
.
Shaptic
changed the title
Replace
Replace Aug 19, 2024
getLedgerEntries()
with a proxy to Core's /getledgerentrybulk
.getLedgerEntries()
with a proxy to Core's /getledgerentry
.
@Shaptic did you start working on this? Otherwise I will take it |
@2opremio this is blocked on Core actually providing this endpoint, but you can take it up if you want to assume the existence of Core's endpoint. I'm working on client support in stellar/go#5428 but again, no real Core yet. Also note that we will still need entry ingestion + db snapshotting until P23. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Protocol 23: Replacing Endpoints
Epic: stellar/go#5433
References: Platform's issues for Protocol 23: projects/37#31
Stellar Core will have support a high-performance HTTP endpoint for retrieving ledger entries as part of their v22 in stellar/stellar-core#4350. Once stellar/go#5426 is complete, we can completely remove the implementation of getLedgerEntries and its database backing and replace it with a proxy to the Core client.
Acceptance Criteria
The database tables are dropped.
The implementation is a proxy to Core.
The returned JSON schema stays the same.
The performance is still acceptable.
The text was updated successfully, but these errors were encountered: