Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.0.0 to main #475

Merged
merged 80 commits into from
Nov 26, 2024
Merged

Release 3.0.0 to main #475

merged 80 commits into from
Nov 26, 2024

Conversation

marcelosalloum
Copy link
Collaborator

What

Release 3.0.0 to main

Checklist

PR Structure

  • This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR title and description are clear enough for anyone to review it.
  • This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

  • No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
  • No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
  • No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
  • No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

  • This is not a breaking change.
  • This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

  • Does the deployment work after merging?

dependabot bot and others added 30 commits July 28, 2024 02:59
Bumps the all-docker group with 2 updates: golang and ubuntu.


Updates `golang` from 1.22.1-bullseye to 1.22.5-bullseye

Updates `ubuntu` from 22.04 to 24.04

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-docker
- dependency-name: ubuntu
  dependency-type: direct:production
  dependency-group: all-docker
...

Signed-off-by: dependabot[bot] <support@github.com>
* Bump the minor-and-patch group across 1 directory with 12 updates

Bumps the minor-and-patch group with 11 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) | `1.45.26` | `1.55.5` |
| [github.com/go-chi/chi/v5](https://github.com/go-chi/chi) | `5.0.10` | `5.1.0` |
| [github.com/go-chi/httprate](https://github.com/go-chi/httprate) | `0.8.0` | `0.12.0` |
| [github.com/jmoiron/sqlx](https://github.com/jmoiron/sqlx) | `1.3.5` | `1.4.0` |
| [github.com/nyaruka/phonenumbers](https://github.com/nyaruka/phonenumbers) | `1.1.8` | `1.4.0` |
| [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) | `1.17.0` | `1.19.1` |
| [github.com/rubenv/sql-migrate](https://github.com/rubenv/sql-migrate) | `1.5.2` | `1.7.0` |
| [github.com/segmentio/kafka-go](https://github.com/segmentio/kafka-go) | `0.4.46` | `0.4.47` |
| [github.com/spf13/cobra](https://github.com/spf13/cobra) | `1.7.0` | `1.8.1` |
| [github.com/twilio/twilio-go](https://github.com/twilio/twilio-go) | `1.11.0` | `1.22.3` |
| [golang.org/x/crypto](https://github.com/golang/crypto) | `0.22.0` | `0.25.0` |



Updates `github.com/aws/aws-sdk-go` from 1.45.26 to 1.55.5
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.45.26...v1.55.5)

Updates `github.com/go-chi/chi/v5` from 5.0.10 to 5.1.0
- [Release notes](https://github.com/go-chi/chi/releases)
- [Changelog](https://github.com/go-chi/chi/blob/master/CHANGELOG.md)
- [Commits](go-chi/chi@v5.0.10...v5.1.0)

Updates `github.com/go-chi/httprate` from 0.8.0 to 0.12.0
- [Release notes](https://github.com/go-chi/httprate/releases)
- [Commits](go-chi/httprate@v0.8.0...v0.12.0)

Updates `github.com/jmoiron/sqlx` from 1.3.5 to 1.4.0
- [Release notes](https://github.com/jmoiron/sqlx/releases)
- [Commits](jmoiron/sqlx@v1.3.5...v1.4.0)

Updates `github.com/nyaruka/phonenumbers` from 1.1.8 to 1.4.0
- [Release notes](https://github.com/nyaruka/phonenumbers/releases)
- [Changelog](https://github.com/nyaruka/phonenumbers/blob/main/CHANGELOG.md)
- [Commits](nyaruka/phonenumbers@v1.1.8...v1.4.0)

Updates `github.com/prometheus/client_golang` from 1.17.0 to 1.19.1
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.17.0...v1.19.1)

Updates `github.com/rubenv/sql-migrate` from 1.5.2 to 1.7.0
- [Commits](rubenv/sql-migrate@v1.5.2...v1.7.0)

Updates `github.com/segmentio/kafka-go` from 0.4.46 to 0.4.47
- [Release notes](https://github.com/segmentio/kafka-go/releases)
- [Commits](segmentio/kafka-go@v0.4.46...v0.4.47)

Updates `github.com/spf13/cobra` from 1.7.0 to 1.8.1
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.7.0...v1.8.1)

Updates `github.com/twilio/twilio-go` from 1.11.0 to 1.22.3
- [Release notes](https://github.com/twilio/twilio-go/releases)
- [Changelog](https://github.com/twilio/twilio-go/blob/main/CHANGES.md)
- [Commits](twilio/twilio-go@v1.11.0...v1.22.3)

Updates `golang.org/x/crypto` from 0.22.0 to 0.25.0
- [Commits](golang/crypto@v0.22.0...v0.25.0)

Updates `golang.org/x/exp` from 0.0.0-20231006140011-7918f672742d to 0.0.0-20240525044651-4c93da0ed11d
- [Commits](https://github.com/golang/exp/commits)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: minor-and-patch
- dependency-name: github.com/go-chi/chi/v5
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: minor-and-patch
- dependency-name: github.com/go-chi/httprate
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: minor-and-patch
- dependency-name: github.com/jmoiron/sqlx
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: minor-and-patch
- dependency-name: github.com/nyaruka/phonenumbers
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: minor-and-patch
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: minor-and-patch
- dependency-name: github.com/rubenv/sql-migrate
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: minor-and-patch
- dependency-name: github.com/segmentio/kafka-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: minor-and-patch
- dependency-name: github.com/spf13/cobra
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: minor-and-patch
- dependency-name: github.com/twilio/twilio-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: minor-and-patch
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: minor-and-patch
- dependency-name: golang.org/x/exp
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: minor-and-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update go.list

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marcelo Salloum <marcelo@stellar.org>
Co-authored-by: Marcelo Salloum dos Santos <marcelosalloum@gmail.com>
)

### What

Replace usage of `docker-compose` with `docker compose` in the CI workflows and the `*.sh` scripts.

### Why

`docker-compose`, AKA Compose V1, stopped receiving updates on July 2023 and the [Docker official documentation says](https://docs.docker.com/compose/migrate/#what-are-the-differences-between-compose-v1-and-compose-v2) it should be replaced by `docker compose`, AKA Compose V2:

<img width="826" alt="Screenshot 2024-08-02 at 3 32 16 PM" src="https://github.com/user-attachments/assets/6ff7291f-9e7e-423d-b8e9-fcf9a07089d8">

Since the versions of our CI actions were updated by dependabot, our CI jobs that used docker-compose started failing, surfacing the problem now that the latest docker versions stopped supporting docker-compose.
* SDP-1307 track verification channel

* SDP-1307 address PR reviews
* SDP-1203 Add Circle Metrics

* SDP-1203 address PR reviews
…nd phoneNumber (#406)

### What

Add an initial screen so receivers can select between email and phone number.

As part of it, I refactored the code to streamline it and rely on reusable methods rather than manipulating the HTML elements directly all the time.

#### Screenshots:

##### New Initial Screen

<img width="500" alt="Screenshot 2024-08-30 at 4 02 18 PM" src="https://github.com/user-attachments/assets/f2c17e8b-6c44-497e-a371-22849f802bac">

##### Email Input Screen

<img width="499" alt="Screenshot 2024-08-30 at 4 02 32 PM" src="https://github.com/user-attachments/assets/cc298ed7-b6c2-448d-8bfc-78a2da58daf6">

### Why

Address https://stellarorg.atlassian.net/browse/SDP-1295
### What

Fix inconsistency in the usage of verification_field vs verification_type:
1. The JSON response from `/wallet-registration/otp` contains a field named `verification_field`, while `/wallet-registration/verification` was expecting that same field to be named `verification_type`. This was fixed in f06f8d6.
2. Renamed the enum `VerificationField*` to `VerificationType*`. Fixed in 2350f5f.

FYI: I tested the disbursement end2end with this change and it works as expected. Nothing was broken.

### Why

The database has the following naming structure:
- The enum for **type** is called `verification_type`, and it can contain values like DATE_OF_BIRTH, PIN, NATIONAL_ID and YEAR_AND_MONTH is called.
- The column names that adhere to that type are called `verification_field`.

That caused some confusion and led to some naming mistakes in the code.
…ent` (#412)

* SDP-1316 Rename `shouldSendInvitationSMS` to `shouldSendInvitation`

* SDP-1316 Rename sms related fields in organizations and disbursements

* SDP-1316 Rename `receiver_invitation_resend_interval` to `receiver_invitation_resend_interval_days`

* SDP-1316 Rename variables mentioning SMS

* SDP-1316 Fix helm chart readme
…h email as well (#413)

### What

Update `POST /wallet-registration/otp` to send OTPs through email as well.

### Why

Address https://stellarorg.atlassian.net/browse/SDP-1296
@marcelosalloum marcelosalloum had a problem deploying to Receiver Registration - E2E Integration Tests (Circle) November 26, 2024 02:17 — with GitHub Actions Error
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 04:16 — with GitHub Actions Inactive
marcelosalloum and others added 3 commits November 26, 2024 11:00
…ing `make docker-build`" (#478)

### What

Revert PR #450: "[SDP-1379] Properly inject the commit hash when running `make docker-build`"

Also, included the `-ldflags "-X main.GitCommit=$GIT_COMMIT"` argument on the delve build, which will probably solve the issue.

### Why

Some users reported the issue below with the code added to the Dockerfile
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 19:01 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 19:02 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Anchor Integration Tests November 26, 2024 19:02 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum had a problem deploying to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 19:02 — with GitHub Actions Failure
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 19:02 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum had a problem deploying to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 19:02 — with GitHub Actions Failure
@marcelosalloum marcelosalloum had a problem deploying to Receiver Registration - E2E Integration Tests (Circle) November 26, 2024 19:02 — with GitHub Actions Error
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 19:02 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Anchor Integration Tests November 26, 2024 19:02 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum had a problem deploying to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 19:02 — with GitHub Actions Failure
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 19:02 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum had a problem deploying to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 19:02 — with GitHub Actions Error
@marcelosalloum marcelosalloum had a problem deploying to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 19:02 — with GitHub Actions Error
@marcelosalloum marcelosalloum had a problem deploying to Receiver Registration - E2E Integration Tests (Circle) November 26, 2024 19:02 — with GitHub Actions Error
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 21:00 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 21:00 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Stellar) November 26, 2024 21:00 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum had a problem deploying to Receiver Registration - E2E Integration Tests (Circle) November 26, 2024 21:00 — with GitHub Actions Failure
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests (Circle) November 26, 2024 21:15 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum merged commit f635986 into main Nov 26, 2024
27 of 30 checks passed
@marcelosalloum marcelosalloum deleted the release/3.0.0 branch November 26, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants