-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contract init: add flag removal message #1628
Conversation
2298378
to
2ea8dee
Compare
# Conflicts: # cmd/soroban-cli/src/commands/contract/init.rs # cmd/soroban-cli/src/utils.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm! 👍
One additional thing that we can do as part of this PR is to remove the gix
dependency - I think it was only being used for this command.
Also, I changed it in #1660 (which will not be necessary after this PR), but I think we'll want to move the |
@Ifropc I pushed a change reverting the Cargo.lock file, and then applying the minimal changes. It reduced the changes to the lock file from 1871 lines, to 899 lines. You may have done an update of all crates accidentally. |
This change appears to be missing the |
@leighmcculloch yes, the other changes are coming in a separate PR, Nando requested to split them for easier review |
Thank you! This is strange, because I got lockfile from main and then just ran |
# Conflicts: # cmd/soroban-cli/src/utils.rs
What
We plan to remove some flags from
![out](https://private-user-images.githubusercontent.com/62526399/371234531-cd22ae4c-4e68-4086-8a46-627f0c89a2cf.svg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyODU5NTYsIm5iZiI6MTczOTI4NTY1NiwicGF0aCI6Ii82MjUyNjM5OS8zNzEyMzQ1MzEtY2QyMmFlNGMtNGU2OC00MDg2LThhNDYtNjI3ZjBjODlhMmNmLnN2Zz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDE0NTQxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkxZTFkYTA3OTIyMjcxZDdlZDlkYzgzYzM4MDg3NmM4Y2JmODlkMDQ4YjUyOTQ0Y2FmNDc5MTg1MDMyNTI3OTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.TMNk3QUbV9xV0lnYsGYEDOu2SsvtZMWfDBQrLu-PpTg)
contract init
as part of breaking changes (see #1586). This PR does just that.Removed argument are hidden from help:
And when trying to use them there's an error that explains what are the alternatives.
Why
See above
Known limitations
N/A