Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract init: add flag removal message #1628

Merged
merged 15 commits into from
Oct 10, 2024
Merged

Contract init: add flag removal message #1628

merged 15 commits into from
Oct 10, 2024

Conversation

Ifropc
Copy link
Contributor

@Ifropc Ifropc commented Sep 25, 2024

What

We plan to remove some flags from contract init as part of breaking changes (see #1586). This PR does just that.
Removed argument are hidden from help:
out

And when trying to use them there's an error that explains what are the alternatives.

error: invalid value 'test' for '--with-example <WITH_EXAMPLE>': This argument has been removed and will be not be recognized by the future versions of CLI: Adding examples via cli is no longer supported. You can still clone examples from the repo https://github.com/stellar/soroban-examples

For more information, try '--help'.

Why

See above

Known limitations

N/A

@Ifropc Ifropc mentioned this pull request Sep 25, 2024
@Ifropc Ifropc changed the title Contract init: add removal memo Contract init: add flag removal message Sep 26, 2024
Ifropc added 2 commits October 4, 2024 11:19
# Conflicts:
#	cmd/soroban-cli/src/commands/contract/init.rs
#	cmd/soroban-cli/src/utils.rs
cmd/soroban-cli/src/utils.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@elizabethengelman elizabethengelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm! 👍

One additional thing that we can do as part of this PR is to remove the gix dependency - I think it was only being used for this command.

cmd/soroban-cli/src/commands/network/container/shared.rs Outdated Show resolved Hide resolved
@elizabethengelman
Copy link
Contributor

Also, I changed it in #1660 (which will not be necessary after this PR), but I think we'll want to move the init integration test into the integration dir. I think as it is now, it is not running.

Cargo.lock Outdated Show resolved Hide resolved
@leighmcculloch
Copy link
Member

There are a lot of changes coming from re-generated lockfile, but I assume it should not be a problem (especially considering we are releasing 22.0 🤔 )

@Ifropc I pushed a change reverting the Cargo.lock file, and then applying the minimal changes. It reduced the changes to the lock file from 1871 lines, to 899 lines. You may have done an update of all crates accidentally.

cmd/soroban-cli/src/utils.rs Outdated Show resolved Hide resolved
@leighmcculloch
Copy link
Member

This change appears to be missing the --name option that's mentioned in #1586. Is that coming in a separate PR?

@Ifropc
Copy link
Contributor Author

Ifropc commented Oct 10, 2024

@leighmcculloch yes, the other changes are coming in a separate PR, Nando requested to split them for easier review
#1625

@Ifropc
Copy link
Contributor Author

Ifropc commented Oct 10, 2024

It reduced the changes to the lock file from 1871 lines, to 899 lines. You may have done an update of all crates accidentally.

Thank you! This is strange, because I got lockfile from main and then just ran cargo build (nothing else 🤔 )

@Ifropc Ifropc enabled auto-merge (squash) October 10, 2024 17:27
@Ifropc Ifropc merged commit a1ee944 into main Oct 10, 2024
24 checks passed
@Ifropc Ifropc deleted the init-deprecate branch October 10, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants