Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Fix operations participants logic to include InvokeHostFunction operation #5574

Merged
merged 7 commits into from
Jan 23, 2025

Conversation

urvisavla
Copy link
Contributor

@urvisavla urvisavla commented Jan 16, 2025

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've reviewed the changes in this PR and if I consider them worthwhile for being mentioned on release notes then I have updated the relevant CHANGELOG.md within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Updates participant detection logic for the InvokeHostFunction operation type. When a smart contract is invoked, the accounts affected will be identified by iterating through the events. Additionally, the logic examines the list of changes resulting from the operation to ensure all affected accounts are detected.

All SAC integration tests have been updated to verify that the accounts/<>/operations endpoint correctly returns the InvokeHostFunction operation for the affected accounts.

Why

Fixes #5538

Known limitations

  • Currently, only burn, mint, clawback and transfer events processed to determine affected accounts since Horizon recognizes only those events.
  • Ingestion filtering based on assets and accounts does not currently handle those affected by invoking smart contract. This should be addressed as a separate scope of work.

@urvisavla urvisavla force-pushed the 5538/invokehostfn-participants branch from cc4fe9c to fe6e1cc Compare January 16, 2025 23:14
@urvisavla urvisavla changed the title services/horizon: Fix operations participants logic to include Invoke… services/horizon: Fix operations participants logic to include InvokeHostFunction operation Jan 21, 2025
@urvisavla urvisavla force-pushed the 5538/invokehostfn-participants branch from 76bc1e1 to b334ddd Compare January 21, 2025 22:48
@urvisavla urvisavla marked this pull request as ready for review January 21, 2025 22:48
@urvisavla urvisavla enabled auto-merge (squash) January 23, 2025 00:34
@urvisavla urvisavla merged commit eecf724 into stellar:master Jan 23, 2025
15 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

services/horizon: account operations endpoint does not include all operations affecting the account
3 participants