-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
services/horizon: Fix operations participants logic to include InvokeHostFunction operation #5574
Merged
urvisavla
merged 7 commits into
stellar:master
from
urvisavla:5538/invokehostfn-participants
Jan 23, 2025
Merged
services/horizon: Fix operations participants logic to include InvokeHostFunction operation #5574
urvisavla
merged 7 commits into
stellar:master
from
urvisavla:5538/invokehostfn-participants
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urvisavla
force-pushed
the
5538/invokehostfn-participants
branch
from
January 16, 2025 23:14
cc4fe9c
to
fe6e1cc
Compare
Shaptic
reviewed
Jan 17, 2025
services/horizon/internal/ingest/processors/operations_processor.go
Outdated
Show resolved
Hide resolved
urvisavla
commented
Jan 21, 2025
urvisavla
changed the title
services/horizon: Fix operations participants logic to include Invoke…
services/horizon: Fix operations participants logic to include InvokeHostFunction operation
Jan 21, 2025
urvisavla
commented
Jan 21, 2025
tamirms
reviewed
Jan 21, 2025
services/horizon/internal/ingest/processors/operations_processor.go
Outdated
Show resolved
Hide resolved
tamirms
reviewed
Jan 21, 2025
Shaptic
reviewed
Jan 21, 2025
services/horizon/internal/ingest/processors/transaction_operation_wrapper_test.go
Show resolved
Hide resolved
Shaptic
reviewed
Jan 21, 2025
urvisavla
force-pushed
the
5538/invokehostfn-participants
branch
from
January 21, 2025 22:48
76bc1e1
to
b334ddd
Compare
tamirms
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
CHANGELOG.md
within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Updates participant detection logic for the InvokeHostFunction operation type. When a smart contract is invoked, the accounts affected will be identified by iterating through the events. Additionally, the logic examines the list of changes resulting from the operation to ensure all affected accounts are detected.
All SAC integration tests have been updated to verify that the accounts/<>/operations endpoint correctly returns the InvokeHostFunction operation for the affected accounts.
Why
Fixes #5538
Known limitations