Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest/cdp: fixed producer test for caller ctx cancel to be consistent #5489

Merged
merged 3 commits into from
Oct 8, 2024
Merged

ingest/cdp: fixed producer test for caller ctx cancel to be consistent #5489

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d06613
#5412: fixed producer test for caller ctx cancel to be consistent
sreuland Oct 7, 2024
dd0f2e9
#5412: triaging producer test for caller ctx cancel to be consistent …
sreuland Oct 8, 2024
37eb785
#5412: review feedback on producer test, where to run the ctx cancel
sreuland Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions ingest/cdp/producer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,8 @@ func TestBSBProducerCallerCancelsCtx(t *testing.T) {
BufferedStorageConfig: DefaultBufferedStorageBackendConfig(1),
}

pubConfig.BufferedStorageConfig.NumWorkers = 1

// the buffering runs async, test needs to stub datastore methods for potential invocation,
// but is race, since test also cancels the backend context which started the buffer,
// so, not deterministic, no assert on these.
Expand All @@ -205,15 +207,20 @@ func TestBSBProducerCallerCancelsCtx(t *testing.T) {
FilesPerPartition: 1,
})

mockDataStore.On("GetFile", mock.Anything, "FFFFFFFD--2.xdr.zstd").Return(makeSingleLCMBatch(2), nil)
mockDataStore.On("GetFile", mock.Anything, "FFFFFFFD--2.xdr.zstd").
Run(func(args mock.Arguments) {
cancel()
}).
Return(makeSingleLCMBatch(2), nil)
// this second attempt needs to be mocked, ledger buffer queues this 'next' sequence task automatically
// in getFromLedgerQueue after it receives "FFFFFFFD--2.xdr.zstd", the ctx is not checked then or in
// the async worker routine that receives the task.
mockDataStore.On("GetFile", mock.Anything, "FFFFFFFC--3.xdr.zstd").Return(makeSingleLCMBatch(3), nil)

appCallback := func(lcm xdr.LedgerCloseMeta) error {
return nil
}

cancel()

datastoreFactory = func(_ context.Context, _ datastore.DataStoreConfig) (datastore.DataStore, error) {
return mockDataStore, nil
}
Expand Down
Loading