Fix CI test workflow errors in RecoverySigner unit tests #5398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Recently, we've been seeing the following error in the test workflow
Received unexpected error: pq: duplicate key value violates unique constraint 'pg_authid_rolname_index'
in the RecoverySigner unit test. The first occurrence of this error in recent history was here. After committing the PR that moves Galexie out of experimental, the issue became exacerbated and started failing every time. The RecoverySigner unit test always fails, but not always in the same test, though the error remains the same.This issue arises because multiple concurrent tests are trying to create the same role, resulting in a race condition. It is unclear why we consistently see this issue now; it may be due to the order in which the tests are executed changing after the relocation of Galexie out of experimental.
The solution is to check for the specific error and if it is a duplicate key violation, we know that the role has been created by another concurrent transaction in which case we ignore the error. Any other type of error during role creation will result in the tests failing.
Why
Resolve CI test workflow errors.
Known limitations