Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp/services/ledgerexporter: Refactored docker setup for ledgerexporter to streamline execution #5348

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

urvisavla
Copy link
Contributor

@urvisavla urvisavla commented Jun 14, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Streamline the Docker image by removing the custom start script and enabling direct execution of the ledger-exporter through command line parameters in docker run.

Why

Fixes HUBBLE-374

Known limitations

@urvisavla urvisavla force-pushed the HUBBLE-734/lexie-docker-config branch from 616c0d9 to 03aefc3 Compare June 14, 2024 18:34
@urvisavla urvisavla marked this pull request as ready for review June 14, 2024 18:45
@urvisavla urvisavla changed the title exp/services/ledgerexporter: Streamline docker setup exp/services/ledgerexporter: Refactored docker setup for ledgerexporter to streamline execution Jun 14, 2024
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@urvisavla urvisavla merged commit d62fa1d into stellar:master Jun 14, 2024
31 checks passed
@urvisavla urvisavla deleted the HUBBLE-734/lexie-docker-config branch June 14, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants