-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exp/services/ledgerexporter: Add guide for contributors/developers #5340
Merged
urvisavla
merged 11 commits into
stellar:master
from
urvisavla:HUBBLE-457/lexie-dev-guide
Jun 27, 2024
Merged
exp/services/ledgerexporter: Add guide for contributors/developers #5340
urvisavla
merged 11 commits into
stellar:master
from
urvisavla:HUBBLE-457/lexie-dev-guide
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urvisavla
force-pushed
the
HUBBLE-457/lexie-dev-guide
branch
from
June 12, 2024 00:25
5789124
to
ef18110
Compare
sreuland
reviewed
Jun 18, 2024
sreuland
reviewed
Jun 18, 2024
sreuland
reviewed
Jun 18, 2024
sreuland
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
urvisavla
force-pushed
the
HUBBLE-457/lexie-dev-guide
branch
from
June 20, 2024 21:07
1b1c00d
to
a50324a
Compare
7 tasks
sreuland
reviewed
Jun 25, 2024
sreuland
reviewed
Jun 25, 2024
sreuland
reviewed
Jun 25, 2024
urvisavla
force-pushed
the
HUBBLE-457/lexie-dev-guide
branch
2 times, most recently
from
June 27, 2024 03:33
20a110d
to
bf2c976
Compare
Co-authored-by: shawn <sreuland@users.noreply.github.com>
Co-authored-by: shawn <sreuland@users.noreply.github.com>
Co-authored-by: shawn <sreuland@users.noreply.github.com>
Co-authored-by: shawn <sreuland@users.noreply.github.com>
urvisavla
force-pushed
the
HUBBLE-457/lexie-dev-guide
branch
from
June 27, 2024 17:19
bf2c976
to
723c690
Compare
urvisavla
changed the title
exp/services/ledgerexporter: Initial draft of developer guide
exp/services/ledgerexporter: Add guide for contributors/developers
Jun 27, 2024
chowbao
reviewed
Jun 27, 2024
chowbao
approved these changes
Jun 27, 2024
Shaptic
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👏 I just added some minor notes about typos and cross-references 👍
Co-authored-by: George <Shaptic@users.noreply.github.com>
Co-authored-by: George <Shaptic@users.noreply.github.com>
Co-authored-by: George <Shaptic@users.noreply.github.com>
tamirms
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Add a guide for developers and contributors to complement the Installation and Usage guide.
Why
Fixes HUBBLE-457
Known limitations