support/datastore: Add CRC32C validation when exporting and consuming tx meta files #5310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Add CRC32C validation validation when uploading and downloading tx meta files.
https://stellarorg.atlassian.net/browse/HUBBLE-271https://stellarorg.atlassian.net/browse/HUBBLE-278
Why
From https://cloud.google.com/storage/docs/hashes-etags
Known limitations
Unfortunately, the CRC32 hash must be computed at the beginning of the HTTP request which means we must write out the payload to a temporary buffer instead of computing the hash on the fly.