Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: clean up duplicate captive-core default config files #5293

Merged
merged 2 commits into from
May 9, 2024

Conversation

urvisavla
Copy link
Contributor

@urvisavla urvisavla commented Apr 25, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

We added default captive-core configurations for both pubnet and testnet in the ingest package, so that it can be used by both ledger exporter and Horizon, as they both use captive-core. So removing duplicate files from Horizon and updating it to use the default configuration files from the ingest package.

Why

Reduce maintenance burden and potential of discrepancies in the duplicates.

Known limitations

N/A

@urvisavla urvisavla force-pushed the cleanup-duplicate-config branch 2 times, most recently from e96e9bc to 3dd2e4d Compare May 7, 2024 17:12
@urvisavla urvisavla changed the title servies/horizon: clean up duplicate captive-core default config files services/horizon: clean up duplicate captive-core default config files May 9, 2024
@urvisavla urvisavla marked this pull request as ready for review May 9, 2024 17:39
@urvisavla urvisavla force-pushed the cleanup-duplicate-config branch from 3dd2e4d to 1e35821 Compare May 9, 2024 21:00
@urvisavla urvisavla merged commit 64cb187 into stellar:master May 9, 2024
31 checks passed
@urvisavla urvisavla deleted the cleanup-duplicate-config branch May 9, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants