do not append UNSTABLE to tag for horizon docker builds #5196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What do not append UNSTABLE to tag for horizon docker builds even if unstable core is used ### Why they've decided they want to be able to bundle unstable captivecore with production horizon, so no point in appending UNSTABLE to the tag ### Testing will be tested ### Issue addressed by this PR stellar/ops#2812
jacekn
approved these changes
Feb 6, 2024
mollykarcher
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
do not append UNSTABLE to tag for horizon docker builds even if unstable core is used
Why
they've decided they want to be able to bundle unstable captivecore with production horizon, so no point in appending UNSTABLE to the tag
Testing
https://buildmeister-v3.stellar-ops.com/job/Platform/job/stellar-horizon-docker-builder/149/
Issue addressed by this PR
https://github.com/stellar/ops/issues/2812