[Draft] services/horizon: Cache files downloaded from HAs #5165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
changed the title
Shaptic
force-pushed
the
cache-history-archives
branch
from
8bc7aaf to
777c8ce
Compare
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add an on-disk cache for the ingestion state machine to avoid repeated downloads from the history archives.
Why
This avoids unnecessary retries.
Known limitations
The cache causes errors when:
We need to decide on the appropriate cache size (perhaps making it controllable by a parameter? but I think that's overkill).
We should clean the cache if possible on a clean shutdown.