Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Remove legacy ingest database backend #5162

Merged
merged 6 commits into from
Feb 20, 2024

Conversation

aditya1702
Copy link
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Part of #4855

Removes the legacy database backend for ingestion:

  • standalone core backend
  • remote captive-core backend

Why

Running horizon ingestion with non-captive-core is deprecated and not recommended.

Known limitations

NA

@aditya1702 aditya1702 self-assigned this Jan 16, 2024
@aditya1702 aditya1702 changed the title horizon: Remove legacy ingest database backend services/horizon: Remove legacy ingest database backend Jan 16, 2024
@aditya1702 aditya1702 marked this pull request as ready for review January 17, 2024 21:51
# Conflicts:
#	services/horizon/internal/ingest/main.go
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop ittttt 🗑️

@aditya1702 aditya1702 merged commit 88206d2 into stellar:master Feb 20, 2024
29 checks passed
@aditya1702 aditya1702 deleted the remove-backend-code branch April 9, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants