Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal/ingest/processors: Dedupe participants deterministically #5149

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Jan 3, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

There are a few places in horizon's ingestion code where we extract unique elements (for example, account participants for an operation) using a map data structure. The problem with that approach is that traversing elements in a map in Go produces a random ordering. We want to make horizon's ingestion workflow completely deterministic so this commit uses sorting to extract unique elements instead.

Why

Having a deterministic ingestion workflow makes it easier to test the correctness of ingestion.

Known limitations

N / A

@tamirms tamirms requested a review from a team January 3, 2024 12:46
@tamirms tamirms merged commit 38f67b9 into stellar:master Jan 3, 2024
28 checks passed
@tamirms tamirms deleted the dedupe-deterministic branch January 3, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants