Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal/ingest: Fix error transition in resume state #5132

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Nov 29, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

If there is an error rebuilding trade aggregation buckets we should retry ingesting the ledger. The previous code terminated ingestion entirely when encountering a rebuild trade aggregations error.

Why

Rebuilding trade aggregation buckets could fail because of transient db connection errors. In that scenario we should retry.

Known limitations

[N/A]

If there is an error rebuilding trade aggregation buckets
we should retry ingesting the ledger. The previous code
terminated ingestion entirely when encountering a
rebuild trade aggregations error.
@tamirms tamirms requested a review from a team November 29, 2023 15:17
@tamirms tamirms merged commit d5e0726 into stellar:master Nov 29, 2023
@tamirms tamirms deleted the fix-resume-state branch November 29, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants