Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --stellar-core-url check when DISABLE_TX_SUB=true, INGEST=false #5126

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

aditya1702
Copy link
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Closes #5124

Remove --stellar-core-url check when DISABLE_TX_SUB=true and INGEST=false

Why

We do not require core if there is no transaction submission required or live ingestion.

Known limitations

N/A

@aditya1702 aditya1702 marked this pull request as ready for review November 28, 2023 16:22
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, great test also!

@aditya1702 aditya1702 merged commit ee5c26f into stellar:master Nov 28, 2023
26 checks passed
@aditya1702 aditya1702 deleted the stellar-core-url branch November 28, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

services/horizon: dont' require stellar-core-url when disable-tx-sub=true
2 participants