-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xdr: Sanity-check allocations when decoding #5116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
changed the title
xdr: Enforce maximum decoding allocation size
xdr: Support maximum decoding allocation size
Nov 15, 2023
2opremio
changed the title
xdr: Support maximum decoding allocation size
xdr: Support providing a maximum decoding allocation size
Nov 15, 2023
2opremio
requested review from
tamirms,
leighmcculloch,
Shaptic and
sreuland
November 15, 2023 19:18
Shaptic
reviewed
Nov 15, 2023
sreuland
reviewed
Nov 21, 2023
sreuland
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
2opremio
changed the title
xdr: Support providing a maximum decoding allocation size
xdr: Sanity-check allocations when decoding
Nov 22, 2023
tamirms
reviewed
Nov 22, 2023
2opremio
added a commit
to stellar/stellar-cli
that referenced
this pull request
Nov 23, 2023
This reverts commit 1ee4113 and updates stellar/go to stellar/go#5116
2opremio
added a commit
to 2opremio/soroban-cli
that referenced
this pull request
Nov 23, 2023
This reverts commit 1ee4113 and updates stellar/go to stellar/go#5116
2opremio
added a commit
to stellar/stellar-cli
that referenced
this pull request
Nov 25, 2023
This reverts commit 1ee4113 and updates stellar/go to stellar/go#5116
2opremio
commented
Nov 28, 2023
2opremio
commented
Nov 28, 2023
tamirms
pushed a commit
to tamirms/go
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on stellar/xdrgen#182 and stellar/go-xdr#19