We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We just close the writer side of the pipe but don't wait for the goroutine to exit:
go/ingest/ledgerbackend/stellar_core_runner.go
Lines 197 to 209 in a4e5a3f
This can cause an extra log line to be written after closing the backend, which causes problems in the new Soroban RPC integration tests. See https://github.com/stellar/soroban-rpc/actions/runs/9538438244/job/26287637351?pr=216#step:10:50
In this particular case, from a dangling goroutine is causing a race condition with Go's testing library.
testing
The text was updated successfully, but these errors were encountered:
tamirms
Successfully merging a pull request may close this issue.
We just close the writer side of the pipe but don't wait for the goroutine to exit:
go/ingest/ledgerbackend/stellar_core_runner.go
Lines 197 to 209 in a4e5a3f
This can cause an extra log line to be written after closing the backend, which causes problems in the new Soroban RPC integration tests. See https://github.com/stellar/soroban-rpc/actions/runs/9538438244/job/26287637351?pr=216#step:10:50
In this particular case, from a dangling goroutine is causing a race condition with Go's
testing
library.The text was updated successfully, but these errors were encountered: