Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingestion filtering should take an OR of all filtering rules #5304

Closed
aditya1702 opened this issue May 7, 2024 · 0 comments · Fixed by #5303
Closed

Ingestion filtering should take an OR of all filtering rules #5304

aditya1702 opened this issue May 7, 2024 · 0 comments · Fixed by #5303

Comments

@aditya1702
Copy link
Contributor

aditya1702 commented May 7, 2024

What problem does your feature solve?

Currently the ingestion filtering code will not include a transaction if both account and asset filter rules are enabled AND both rules do not result in a rule match for a given tx - https://github.com/stellar/go/blob/master/services/horizon/internal/ingest/group_processors.go#L189.

What would you like to see?

We want to include transactions using OR logic where it will cycle through all enabled filter rules and include the tx if at least one filter matches.

What alternatives are there?

NA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant