-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Processed Ledger" logged twice during resume state #5152
Labels
Comments
sreuland
added a commit
to sreuland/go
that referenced
this issue
Jan 8, 2024
…dger to be different phrase to avoid conflict with existing 'Processed ledger' log output from fsm
7 tasks
sreuland
added a commit
that referenced
this issue
Jan 8, 2024
… be different phrase to avoid conflict with existing 'Processed ledger' log output from fsm (#5155)
merged |
sreuland
added a commit
to sreuland/go
that referenced
this issue
Jan 29, 2024
…dger to be different phrase to avoid conflict with existing 'Processed ledger' log output from fsm (stellar#5155)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
In the release-horizon-v2.28.0 branch, the "Processed Ledger" message is logged twice whenever a ledger is ingested in the resume state:
The first case includes a duration field which measures the total time to ingest the ledger through all the processors.
The second case also includes a duration field, however, that field only measures the time to run the transaction processors.
We should only be logging the first case during resume state ingestion. This bug was introduced in #5117
In 2.27.0 we never logged the "Processed Ledger" message in processor runner:
https://github.com/stellar/go/blob/release-horizon-v2.27.0/services/horizon/internal/ingest/processor_runner.go
The "Processed Ledger" message was logged only in fsm during the resume state and the other states which only reingested history. We should fix this bug and ensure that "Processed Ledger" is only logged once per ledger in every state of the fsm (resume, reingest history, etc)
The text was updated successfully, but these errors were encountered: