Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/ingest: remove the force flag on reingestion cmds #5128

Closed
sreuland opened this issue Nov 28, 2023 · 1 comment
Closed

services/horizon/ingest: remove the force flag on reingestion cmds #5128

sreuland opened this issue Nov 28, 2023 · 1 comment
Labels
feature request ingest New ingestion system performance issues aimed at improving performance

Comments

@sreuland
Copy link
Contributor

sreuland commented Nov 28, 2023

What problem does your feature solve?

the force flag is incompatible with the new flushed data-flow of ingestion where we batch multiple ledgers in a single transaction, done in prior #5099

What would you like to see?

removal of force flag to avoid unintended mis-use

What alternatives are there?

@tamirms
Copy link
Contributor

tamirms commented Jan 5, 2024

Actually, we can close this issue. The force flag is only incompatible when you have parallel workers and we already check for that:

https://github.com/stellar/go/blob/master/services/horizon/cmd/db.go#L398-L400

@tamirms tamirms closed this as completed Jan 5, 2024
@github-project-automation github-project-automation bot moved this from Next Sprint Proposal to Done in Platform Scrum Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request ingest New ingestion system performance issues aimed at improving performance
Projects
Status: Done
Development

No branches or pull requests

2 participants