Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message #1354

Merged
merged 1 commit into from
May 8, 2024
Merged

Improve error message #1354

merged 1 commit into from
May 8, 2024

Conversation

Ifropc
Copy link
Contributor

@Ifropc Ifropc commented May 7, 2024

Description

Improve error message on Horizon errors

Context

Current error message simply says Error response from the server without any explanation

Testing

  • ./gradlew test

Documentation

N/A

Known limitations

N/A

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Code Coverage

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

lijamie98
lijamie98 approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@lijamie98 lijamie98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ifropc Ifropc merged commit 2bbbb7b into develop May 8, 2024
8 checks passed
@Ifropc Ifropc deleted the improve-message branch May 8, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lijamie98 lijamie98 lijamie98 approved these changes

@philipliu philipliu Awaiting requested review from philipliu

@JiahuiWho JiahuiWho Awaiting requested review from JiahuiWho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ifropc @lijamie98