Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle uppercase "Y" properly during install #40

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Handle uppercase "Y" properly during install #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bin/install
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ initiate() {

echo

if [ "$yes_g" != "y" ]; then
if [ "${yes_g,,}" != "y" ]; then
Copy link
Owner

@stefanmaric stefanmaric Oct 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not POSIX syntax (see CI) (and thank God, because this is super hard to read).

Would suggest a simple OR operator.

echo "Aborted"
exit 1
fi
Expand Down Expand Up @@ -522,7 +522,7 @@ initiate() {

echo

if [ "$yes_go" != "y" ]; then
if [ "${yes_go,,}" != "y" ]; then
exit 0
fi
fi
Expand Down
Loading