Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of Advanced and Legacy settings in the app #21360

Open
8 tasks
churik opened this issue Oct 1, 2024 · 2 comments
Open
8 tasks

Review of Advanced and Legacy settings in the app #21360

churik opened this issue Oct 1, 2024 · 2 comments

Comments

@churik
Copy link
Member

churik commented Oct 1, 2024

Problem

Following up on this comment:

Currently, the settings we have in Advanced and Legacy are not clearly understandable for users, and some of them were added without the involvement of the QA team.

We need to define how these settings should be used and whether we should remove or hide those that are no longer in use.

Advanced:

  • Log Level: Used by both the QA and development teams.
  • Fleet: Used by both the QA and development teams.
  • Waku V2 Settings: There is no information regarding when this was added or its purpose. It recently caused a crash on tap, which has since been fixed.
  • Peers Stat: Used by the QA team.
  • Light Client: Enabled by default and currently in use.
  • Store Confirmations: Disabled by default. This is a debug setting that was used to show store confirmations, which were unstable. It is not currently used by the QA team but may be useful for debugging in the future.
  • Peer Syncing: The purpose and expected functionality of this toggle are unclear.

Legacy Settings:

  • Sync Settings, which comprise:
    1. Backup Setting (Enabled by default): Used for backing up Waku and can also be used to perform backups. Utilized by the QA team.
    2. Sync History For: I believe (though I'm not 100% certain) that this was implemented only for Waku 1 and was never migrated to V2. This allows us to fetch history from the mail server for more than 24 hours (up to 1 month).
    3. Status Nodes: Configurable store nodes for V1. This was not implemented for V2 and is a leftover from the "Sync Settings" in V1. Relevant issue: #20490 regarding migration from V1.
    4. Devices: Old pairing; if devices were paired on V1, they remain paired on V2. This can also be removed and is a leftover from the "Sync Settings" in V1.

Acceptance criteria

Advanced Settings

  • Waku V2 Settings

    • Investigate when this setting was added and its intended purpose.
    • Assess whether this setting should be retained or removed.
  • Store Confirmations

    • Evaluate the necessity of this debug setting.
    • Determine if it should be kept for potential future debugging use or removed.
  • Peer Syncing

    • Clarify the purpose and expected functionality of this toggle.
    • Decide whether it should be retained or removed.

Legacy Settings

  • Sync Settings
    • Review the following components:

    • Backup Setting

      • Confirm its current usage
      • Identify the place for it, might be moved to Advanced?
    • Sync History For

      • Decide whether it should be retained or removed.
    • Status Nodes

      • Determine if this setting is still relevant, given that it was not implemented for V2.
      • Decide whether it should be retained or removed.
    • Devices

      • Assess if this old pairing feature should be removed, as it is leftover from V1.

Additional Information

  • Status version: nightly 01/10/24
  • Operating System: Android, iOS
@churik
Copy link
Member Author

churik commented Oct 1, 2024

Note: I'd vote for just moving useful leftovers from legacy to advanced

@churik
Copy link
Member Author

churik commented Oct 3, 2024

linking to #21375

It is crucial for us + WAKU team to know to which mailserver app is currently connected. Currently it is not possibel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant