Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimism assets not fully fetched in "Popular Assets" section on swap page #21339

Closed
VolodLytvynenko opened this issue Sep 27, 2024 · 3 comments · Fixed by #20962
Closed

Optimism assets not fully fetched in "Popular Assets" section on swap page #21339

VolodLytvynenko opened this issue Sep 27, 2024 · 3 comments · Fixed by #20962
Assignees
Milestone

Comments

@VolodLytvynenko
Copy link
Contributor

Steps to Reproduce:

  1. Go to the swap page and select the Optimism network.
  2. Check the "Popular Assets" section in the "Asset to Pay" or "Asset to Receive" sheets.

Actual Result:

Only 4 tokens are shown in the "Popular Assets" section for Optimism.

4tokens.mp4

Expected Result:

More popular tokens should be displayed in the "Popular Assets" section for the Optimism network, as on Desktop

swap.mp4

Devices:

  • Pixel 7a, Android 13
  • iPhone 11 Pro Max, IOS 17

Logs:

logs.zip

@VolodLytvynenko
Copy link
Contributor Author

It seems that Status Go isn't returning the full list of tokens, but I checked, and it works well with the latest desktop.

@churik churik changed the title Optimism assets not fully fetched in "Popular Assets" section on swap paeg Optimism assets not fully fetched in "Popular Assets" section on swap page Oct 1, 2024
@churik churik added the Swap M1 label Oct 1, 2024
@briansztamfater briansztamfater self-assigned this Oct 3, 2024
@briansztamfater
Copy link
Member

Based on my investigation, this is not a status-go issue. I pushed the fix in #20962 because the bug was affecting the implementation of that flow as well.

@VolodLytvynenko
Copy link
Contributor Author

Based on my investigation, this is not a status-go issue. I pushed the fix in #20962 because the bug was affecting the implementation of that flow as well.

hi @briansztamfater Thank you for checking it. I thought this was related to the status go based on #21140 (comment) after reporting this issue in PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants