Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lug-helper.sh: Pin winetricks version to 20250102 #102

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

ProjectSynchro
Copy link
Contributor

I added a simple version variable to ensure we only download the same version of winetricks every time.

Since all the verbs being used during setup have stabilized and will grab their latest versions from GitHub (DXVK and the powershell wrapper come to mind) it makes sense to pin the version of winetricks being used for the sake of repeatable wineprefix installs.

This would protect against bugs like: Winetricks/winetricks#2325 which until Winetricks/winetricks#2326 is merged will cause wineprefix installs to fail for no reason.

@Termuellinator
Copy link
Contributor

Sounds like a sane (pun intended ;) ) idea to me, thank you!
I don´t really see any real possibility for adverse effects, do you @the-sane ?

@the-sane
Copy link
Member

Thanks for updating this! I've been quite busy lately but we'd been waiting for this year's release and never intended to keep it on the main branch downloads. Now that it's out this makes sense.

@ProjectSynchro Sounds like this is causing issues with everyone's installs? Do I need to push out a new Helper release with this change?

@the-sane the-sane merged commit 4e90c8f into starcitizen-lug:main Jan 22, 2025
@ProjectSynchro
Copy link
Contributor Author

Thanks for updating this! I've been quite busy lately but we'd been waiting for this year's release and never intended to keep it on the main branch downloads. Now that it's out this makes sense.

Yeah, luckily all the verbs are pretty much future proof since they download the latest release :)

@ProjectSynchro Sounds like this is causing issues with everyone's installs? Do I need to push out a new Helper release with this change?

I think so :) Definitely would make the most sense. I patched the Fedora package with this change but having it everywhere is a good idea.

I haven't checked the upstream PR, but considering how long it can take for some PRs to be merged I wouldn't be surprised if it stays broken for a bit longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants