Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard 2.0 #11

Open
1 of 6 tasks
antoinefalisse opened this issue Jan 20, 2023 · 3 comments
Open
1 of 6 tasks

Dashboard 2.0 #11

antoinefalisse opened this issue Jan 20, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@antoinefalisse
Copy link
Collaborator

antoinefalisse commented Jan 20, 2023

Wish list:

  • Change plotting library to Chart.JS (same as in addbiomechanics). This will ease the development of the rest of the elements in the list.
  • Chart persistence
  • option to bring up 3d visualizer to the right of the plot with the time bar, and a vertical line on the plot that allows to scroll thru
  • buttons to add to plot or generate new plot (e.g., so we can add data from a previous session).
  • option to add additional plots

When backend ready:

  • pop-out for additional analyses that can be done. You can select the session, trial, and analysis. Once you "launch" the analysis, it will get queued for backend, and the trial will show up in a list with colored dots, like we have in step 5.

@suhlrich and @AlbertoCasasOrtiz, feel free to edit. I feel like getting the visualizer synced with the plots is the most important item of this list and that the other items could be in a later version

@AlbertoCasasOrtiz
Copy link
Collaborator

AlbertoCasasOrtiz commented May 9, 2023

I've been working on this issue since Friday and I have some updates and thoughts:

  1. I have the new library, chart-js, working. There are only a few tasks to do:
    1.1. Allow download chart. Since we changed the library, now the download methods are different.
    1.2. Zoom. The new library does not allow zooming in/out, but I found a plugin for it that allows zooming with the mouse wheel.
    1.3. Adjust height.
    1.4. Allow users adjust size of title and axis labels? It is too small for my eyes.
  2. I've been thinking, and I think we should make charts persistent. Right now, if you create a chart and you exit or refresh, everything is lost. This would imply changes in database mainly. If we make charts persistent (basically we would only have to save into the database the chart options and the session id it belongs), people could share charts.
  3. I have added a new functionality, now you can select color scales for the chart. I set the viridis palette as default since it is good for visualization, when transformed to black and white, and it is accessible for color blind people.
  4. I fixed some bugs.

@antoinefalisse, @suhlrich let me know your thoughts, especially about the data persistence issue.

A preview of how the new library looks like:

Capture

@suhlrich
Copy link
Member

suhlrich commented May 9, 2023

Great! I think the chart settings persistence is a nice idea. I wonder if we'd want to do it on a per-user basis. I could imagine a user wanting to create the same chart for multiple sessions. For example, you could save the chart settings to your profile, then pick one from a drop-down. This would require changing the database model, but that's ok probably.

@AlbertoCasasOrtiz
Copy link
Collaborator

New update on this.

I think we should review and merge if everything is working properly now, since many changes are accumulated. The full list of changes is on this PR: #100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants