Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app.py is overlooking 404 (and probably other) statuses #230

Open
AlbertoCasasOrtiz opened this issue Jan 29, 2025 · 0 comments
Open

app.py is overlooking 404 (and probably other) statuses #230

AlbertoCasasOrtiz opened this issue Jan 29, 2025 · 0 comments
Assignees
@carmichaelong @AlbertoCasasOrtiz
Labels
invalid This doesn't seem right question Further information is requested

Comments

@AlbertoCasasOrtiz
Copy link
Collaborator

With the new implementation of retry requests, we have noticed that the current request is overlooking when a 404 status is returned. In this case, it is trying to access and process trials that do not exist.

opencap-core/app.py

Line 152 in 9d139da

r = requests.patch(trial_url, data={"status": "done"},

@AlbertoCasasOrtiz AlbertoCasasOrtiz added invalid This doesn't seem right question Further information is requested labels Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carmichaelong carmichaelong

@AlbertoCasasOrtiz AlbertoCasasOrtiz

Labels
invalid This doesn't seem right question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carmichaelong @AlbertoCasasOrtiz