-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed Observ Charts #109
fixed Observ Charts #109
Conversation
k8s/services/grafana/helm-8.5.cue
Outdated
datasources: { | ||
"datasources.yaml": { | ||
apiVersion: 1 | ||
datasources: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this field cannot be overriden, CUE will prevent this, you should define a schema instead and add these data sources as the default values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to test this try installing the observability stack in a namespace other than "monitoring", you'll need then to override the data source URLs to use the different namespace but will not be able to do this
) | ||
|
||
ObservabilityStack: v1.#Stack & { | ||
$metadata: stack: "ObservabilityStack" | ||
components: { | ||
"loki": loki.#LokiChart & { | ||
helm: { | ||
version: "6.16.0" | ||
version: "2.10.2" | ||
release: "loki" | ||
values: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this prevents the user from overriding the chart's default values, CUE will complain
release: "loki" | ||
values: {} | ||
} | ||
} | ||
"grafana": grafana.#GrafanaChart & { | ||
helm: { | ||
version: "8.5.1" | ||
version: "8.5.11" | ||
release: "grafana" | ||
values: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this prevents the user from overriding the chart's default values, CUE will complain
k8s/stacks/observ.cue
Outdated
@@ -31,5 +32,15 @@ ObservabilityStack: v1.#Stack & { | |||
values: {} | |||
} | |||
} | |||
"pixie": pixie.#PixieChart & { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pixie should be optional and disabled by default
k8s/stacks/observ.cue
Outdated
helm: { | ||
version: "0.1.6" | ||
release: "pixie" | ||
values: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this prevents the user from overriding the chart's default values, CUE will complain
k8s/stacks/observ.cue
Outdated
release: "pixie" | ||
values: { | ||
clusterName: "ObservTest" | ||
deployKey: "px-dep-7f20ab42-b199-418f-872b-f5a84378152f" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this hard coded?
…w overriding the default values of the charts
…w overriding the default values of the charts
…w overriding the default values of the charts
…w overriding the default values of the charts
…w overriding the default values of the charts
No description provided.