Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Observ Charts #109

Merged
merged 23 commits into from
Nov 29, 2024
Merged

fixed Observ Charts #109

merged 23 commits into from
Nov 29, 2024

Conversation

Omar-Ahmed-Dt
Copy link
Collaborator

No description provided.

datasources: {
"datasources.yaml": {
apiVersion: 1
datasources: [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this field cannot be overriden, CUE will prevent this, you should define a schema instead and add these data sources as the default values

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to test this try installing the observability stack in a namespace other than "monitoring", you'll need then to override the data source URLs to use the different namespace but will not be able to do this

)

ObservabilityStack: v1.#Stack & {
$metadata: stack: "ObservabilityStack"
components: {
"loki": loki.#LokiChart & {
helm: {
version: "6.16.0"
version: "2.10.2"
release: "loki"
values: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this prevents the user from overriding the chart's default values, CUE will complain

release: "loki"
values: {}
}
}
"grafana": grafana.#GrafanaChart & {
helm: {
version: "8.5.1"
version: "8.5.11"
release: "grafana"
values: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this prevents the user from overriding the chart's default values, CUE will complain

@@ -31,5 +32,15 @@ ObservabilityStack: v1.#Stack & {
values: {}
}
}
"pixie": pixie.#PixieChart & {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pixie should be optional and disabled by default

helm: {
version: "0.1.6"
release: "pixie"
values: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this prevents the user from overriding the chart's default values, CUE will complain

release: "pixie"
values: {
clusterName: "ObservTest"
deployKey: "px-dep-7f20ab42-b199-418f-872b-f5a84378152f"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this hard coded?

@kajogo777 kajogo777 merged commit a76a824 into main Nov 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants