Fix first-class citizenship simnet wallet balances #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugocaillard
reviewed
Feb 7, 2025
moodmosaic
reviewed
Feb 7, 2025
There was a problem hiding this comment.
Good catch! Users would definitely expect rv to respect their .toml file. Nice spot, @BowTiedRadone! Thanks for checking as well, @hugocaillard.
🚀
Co-authored-by: Nikos Baxevanis <nikos.baxevanis@gmail.com>
BowTiedRadone
force-pushed
the
fix/wallet-stx-balances
branch
from
147779e to
cbc9388
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
issueFirstClassCitizenship. TheinitEmptySessionmethod did not set wallet balances fromDevnet.toml, causing all simnet accounts to start with 0 STX. This fix ensures that after initializing a new session, the correct STX balances are minted as specified inDevnet.toml.