make lint now checks for format
#656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables `make lint` to also run black but without persisting the changes. This will hopefully allow developers to more easily detect if their changes are not compliant with the linter settings. This also removes the `make format` call from CI, which didn't actually fail if linter issues were found. Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
aponcedeleonch
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables
make lintto also run black but without persisting thechanges. This will hopefully allow developers to more easily detect if
their changes are not compliant with the linter settings.
This also removes the
make formatcall from CI, which didn't actuallyfail if linter issues were found.
Signed-off-by: Juan Antonio Osorio ozz@stacklok.com