fix: correct the way to get the last relevant user message for secrets #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When showing new secrets detection, we were just picking from last assistant message id. But in the case of aider, we need to pick more user messages. So reuse the logic of the method to get the relevant user block, to pick the index from the relevant user message and start counting from there Closes: #606
JAORMX
previously approved these changes
Jan 16, 2025
jhrozek
previously approved these changes
Jan 16, 2025
jhrozek
approved these changes
Jan 16, 2025
lukehinds
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When showing new secrets detection, we were just picking from last assistant message id. But in the case of aider, we need to pick more user messages. So reuse the logic of the method to get the relevant user block, to pick the index from the relevant user message and start counting from there
Closes: #606