fix: only record db content if it is the last chunk in stream #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For copilot chat, we are actually receiving multiple streams, and we were recording entries and alerts for each one, repeating those. So detect if we are in the last chunk and propagate it to the pipeline, so we can record it only in this case, avoiding dupes. In the case of other providers, we only receive one request, so always force saving it Closes: #936
yrobla
requested review from
aponcedeleonch,
jhrozek and
JAORMX
and removed request for
aponcedeleonch and
jhrozek
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For copilot chat, we are actually receiving multiple streams, and we were recording entries and alerts for each one, repeating those. So detect if we are in the last chunk and propagate it to the pipeline, so we can record it only in this case, avoiding dupes. In the case of other providers, we only receive one request, so always force saving it
Closes: #936